[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 24 11:24:25 PST 2017


lebedev.ri updated this revision to Diff 128113.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

In https://reviews.llvm.org/D41512#963743, @dim wrote:

> We now still have to explicitly use `-Wno-tautological-constant-compare` everywhere. :-(


OTOH, thank you for bringing this up once again. I did thought previously about
moving this specific warning into it's own flag, but never really looked into it.
But now i did, so hopefully this should be even better now :)


Repository:
  rC Clang

https://reviews.llvm.org/D41512

Files:
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticSemaKinds.td
  test/Sema/tautological-constant-compare.c
  test/Sema/tautological-constant-enum-compare.c
  test/SemaCXX/compare.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41512.128113.patch
Type: text/x-patch
Size: 5132 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171224/f34f0f0c/attachment.bin>


More information about the cfe-commits mailing list