[PATCH] D41495: [clangd] Skip function bodies when building the preamble

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 21 23:29:49 PST 2017

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Those are some impressive numbers!
Excited to see this land, thanks for tracking down all the weird problems.

Comment at: clangd/ClangdUnit.cpp:536
+      // so we set SkipFunctionBodies back to false after preamble is built.
+      assert(!CI->getFrontendOpts().SkipFunctionBodies);
+      CI->getFrontendOpts().SkipFunctionBodies = true;
Nit: I think the comment/assert focus too much on the 'what' at the expense of the 'why' - just the first sentence here is probably enough (without the second and without the assert).

And below, something like:
    // For the main file, we do want the AST and diagnostics for function bodies. 

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list