[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 21 15:50:50 PST 2017

benlangmuir added a comment.

Did you consider just using a different pragma that triggers this behaviour instead of avoiding the crash?  I don't really have a strong preference but I'd be interested to hear what you think the pros/cons are.

Comment at: lib/Parse/ParseDecl.cpp:5657
+      else
+        PP.getPreprocessorOpts().SeenParserCrashPragma = true;
+    }
This should return immediately (and keep exiting until ~ParseAST) or it won't really behave like a trap.

  rC Clang


More information about the cfe-commits mailing list