[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 21 11:03:57 PST 2017
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgrang, klimek.
This improves a few things:
- the insert -> freeze -> read sequence is now enforced/communicated by the type system
- SymbolSlab::const_iterator iterates over symbols, not over id-symbol pairs
- we avoid permanently storing a second copy of the IDs, and the string map's hashtable
The slab size is now down to 21.8MB for the LLVM project.
Of this only 2.7MB is strings, the rest is #symbols * `sizeof(Symbol)`.
`sizeof(Symbol)` is currently 96, which seems too big - I think
SymbolInfo isn't efficiently packed. That's a topic for another patch!
Also added simple API to see the memory usage/#symbols of a slab, since
it seems likely we will continue to care about this.
rCTE Clang Tools Extra
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 16175 bytes
Desc: not available
More information about the cfe-commits