[PATCH] D40478: Added control flow architecture protection Flag

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 21 10:12:16 PST 2017

craig.topper added a comment.

Are we sure we want a different command line option name from gcc? From our internal conversations with the gcc folks I thought they were suggesting that -fcf-protection could imply a software mechanism if a hardware mechanism was not available thorugh -mibt or -march?

Should we emit an error to the user if -mibt isn't available?  We should be able to add virtual methods on TargetInfo that X86 can customize to check for ibt and shstk.

Can you provide more information about the miscompile on MSVC? I think we should do more to understand that, this sounds like it could be a time bomb waiting to fail somewhere else.



More information about the cfe-commits mailing list