[PATCH] D38639: [clangd] #include statements support for Open definition

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 21 07:39:46 PST 2017


ilya-biryukov added inline comments.


================
Comment at: clangd/XRefs.cpp:183
+      unsigned CharNumber = SourceMgr.getSpellingColumnNumber(
+          DeclMacrosFinder->getSearchedLocation());
+
----------------
ilya-biryukov wrote:
> Replace with `DeclMacrosFinder->getSearchedLocation()` `SourceLocationBeg`, it makes the code easier to read.
Sorry, the comment got messed up. Here's the correct version:

Replace `DeclMacrosFinder->getSearchedLocation()` with `SourceLocationBeg`, it makes the code easier to read.




Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D38639





More information about the cfe-commits mailing list