[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

Peter Szecsi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 21 06:44:09 PST 2017

szepet accepted this revision.
szepet added a comment.

In https://reviews.llvm.org/D41444#961110, @a.sidorin wrote:

> Test both with and without '-fdelayed-template-parsing' in C++ mode.

This solution LGTM as well. 
Just a small nit added inline.

Comment at: unittests/AST/ASTImporterTest.cpp:68
+           const std::string &FromCode, const std::string &ToCode,
+           MatchVerifier<NodeType> &Verifier, const MatcherType &AMatcher) {
   const char *const InputFileName = "input.cc";
Nit: Maybe the order of the parameters could stay similar as the original: FromCode, FromArgs, ToCode, ToArgs, Verifier, AMatcher. (Or just Codes before Args)

It seems more intuitive to me.

  rC Clang


More information about the cfe-commits mailing list