[PATCH] D41483: [clangd] Index symbols share storage within a slab.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 21 06:03:35 PST 2017

ilya-biryukov added inline comments.

Comment at: clangd/index/Index.h:136
+  // Intern table for strings. Not StringPool as we don't refcount, just insert.
+  llvm::StringSet<llvm::BumpPtrAllocator> Strings;
   llvm::DenseMap<SymbolID, Symbol> Symbols;
A comment on why we use `BumpPtrAllocator` here might be useful.
I.e., it uses more memory than malloc, but we're getting better data locality. (I hope that I got its intention right)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list