[PATCH] D41432: [clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 20 03:10:32 PST 2017

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm! This is amazing!

Comment at: unittests/clangd/Annotations.h:12
+//    Annotations Example(R"cpp(
+//       int complete() { x.pri^ }          // ^ indicates a point
Does this support overlapping annotations like (named) points in (named) ranges?

Comment at: unittests/clangd/Annotations.h:45
+  // Crashes if there isn't exactly one.
+  Position point(llvm::StringRef Name = "") const;
+  // Returns the position of all points marked by ^ (or $name^) in the text.
Is this the position in the stripped code or the original text?

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list