[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

Faisal Vali via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 20:33:51 PST 2017

faisalv requested changes to this revision.
faisalv added a comment.
This revision now requires changes to proceed.

Hmm - I think i might make some tweaks to this patch (to be largely symmetric with the similar handling of invalid decl-specifiers on function parameters in Sema::Actions.ActOnParamDeclarator)...

Would you want to try to make those changes and update this diff - or would you rather I make them and commit a patch acknowledging your contribution?

Sorry about not suggesting the changes earlier - but it occurred to me while I was re-reviewing the patch prior to committing it, that we don't handle inline and virtual - which led me to ActOnParamDeclarator ...


More information about the cfe-commits mailing list