[PATCH] D41425: [darwin][driver] Warn about mismatching -<os>-version-min rather than superfluous -<os>-version-min compiler option

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 18:30:22 PST 2017

arphaman added inline comments.

Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+           Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+                                     ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+           VersionTuple(TargetMajor, TargetMinor, TargetMicro) !=
steven_wu wrote:
> arphaman wrote:
> > steven_wu wrote:
> > > HadExtra is not ok right? macos10.11.0.1 is not the same as macos10.11.0?
> > > Or HadExtra is an error somewhere else already?
> > Right, it would be nice to check the extra stuff too. I will commit with the check and a test for the extra part.
> And what about "-target x86_64-apple-macos -mmacos-version-min=10.6"?
We will warn on that.

  rC Clang


More information about the cfe-commits mailing list