[PATCH] D40478: Added control flow architecture protection Flag

Oren Ben Simhon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 12:44:15 PST 2017

oren_ben_simhon marked an inline comment as done.
oren_ben_simhon added inline comments.

Comment at: lib/CodeGen/CodeGenFunction.cpp:876
   // Apply xray attributes to the function (as a string, for now)
-  if (D && ShouldXRayInstrumentFunction()) {
+  bool InstrumentXray = ShouldXRayInstrumentFunction();
+  if (D && InstrumentXray) {
craig.topper wrote:
> Why this change?
Apparently, some compilers do strange optimizations on bit structures (like CodeGenOptions) that cause this code to be compiled wrongly. 
I encountered this issue when i added a new Code Gen Option and compiled clang in windows.
In order to overcome this issue, i changed a bit the code and the wrong optimization didn't occur.



More information about the cfe-commits mailing list