[PATCH] D41368: [libc++] Ignore bogus tautologic comparison warnings

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 08:24:25 PST 2017

mclow.lists added a comment.

In https://reviews.llvm.org/D41368#958865, @zturner wrote:

> It would be better if we could just fix the code.

I disagree (See discussion of https://reviews.llvm.org/D39149). Even if it was "just this one place" (which it isn't), this affects users of clang, not just libc++.
This is a (small, but significant) barrier to people trying to write correct, portable generic code, and clang is just wrong to warn here.

As an aside, I definitely object to "just fix the code". The code is correct as written.
I think what you mean is "it would be better if we could just tell the compiler to shut up"  (which is what you've proposed - but incompletely)

  rCXX libc++


More information about the cfe-commits mailing list