[PATCH] D41280: [clangd] Don't use the optional "severity" when comparing Diagnostic.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 07:49:36 PST 2017


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Sorry, I did miss it!



================
Comment at: clangd/Protocol.h:326
+};
+/// A LSP-specific comparator used to find Disgnostic in a container like
+/// std:map.
----------------
nit: diagnostic


================
Comment at: clangd/Protocol.h:326
+};
+/// A LSP-specific comparator used to find Disgnostic in a container like
+/// std:map.
----------------
sammccall wrote:
> nit: diagnostic
it seems like this could move from Protocol to ClangdLSPServer, but up to you


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41280





More information about the cfe-commits mailing list