[PATCH] D41391: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 07:38:45 PST 2017

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.

Comment at: clangd/clients/clangd-vscode/README.md:16
+To use `vscode-clangd` extension in VS Code, you need to install `vscode-clangd`
+from VS Code extension marketplace.
The fact that you need to install `clangd` seems to belong here, not as "configuration".

Comment at: clangd/clients/clangd-vscode/README.md:39
+* VS Code
+* nodejs and npm

Comment at: clangd/clients/clangd-vscode/package.json:46
+    "repository": {
+      "type": "git",
+      "url": "https://github.com/llvm-mirror/clang-tools-extra/tree/master/clangd/clients/clangd-vscode"
use the SVN path?
npm says this should be a machine readable SCM url, which these github web urls aren't.

consider adding homepage/bugtracker, which are also shown on the marketplace page: https://marketplace.visualstudio.com/items?itemName=tht13.python

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list