[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

Rainer Orth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 04:41:15 PST 2017

ro marked an inline comment as done.
ro added inline comments.

Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
                                     StringRef Sanitizer) {
+  // Solaris ld doesn't need this.  Inhibit use of non-existant
+  // --export-dynamic.
alekseyshl wrote:
> ro wrote:
> > alekseyshl wrote:
> > > Can you elaborate why Solaris ld does not need dynamic lists? How does it export sanitizer symbols then?
> > Solaris ld simply defaults to --export-dynamic.
> Can we say then that ld "defaults to --export-dynamic behavior" (as --export-dynamic does not exists there) instead of "doesn't need this"?
Sure, that's certainly clearer.  As in the revised patch?

  rC Clang


More information about the cfe-commits mailing list