[PATCH] D41367: [clangd] Support filtering by fixing scopes in fuzzyFind.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 03:03:55 PST 2017

ioeric added a comment.

Thanks for the review!

Comment at: clangd/index/Index.h:127
   /// \brief A query string for the fuzzy find. This is matched against symbols'
-  /// qualfified names.
+  /// qualified names. If any scope below is provided, \p Query is only matched
+  /// against symbols in the scope (excl. symbols in nested scopes).
sammccall wrote:
> If i'm reading this right, you still support fuzzy-matching the scopes (scope information can be in Query, or Scopes, or both). Why? Semantics would be simpler if query matched the identifier only.
This makes a lot of sense. 

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list