[PATCH] D39149: [libc++] Prevent tautological comparisons

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 18 13:48:02 PST 2017

mclow.lists added a comment.

In https://reviews.llvm.org/D39149#958378, @bcain wrote:

> Let's resurrect these changes since https://reviews.llvm.org/D39462 was not the right short-term approach.

Let's not.  IMHO, these changes are:

- a bad idea in principle - clang should not be warning here, and
- a bad idea in execution - we don't want to be using `__SIZEOF_INT__` and `__SIZEOF_LONG__`

I'm fine with the realization that "https://reviews.llvm.org/D39462 was not the right short-term approach", but that doesn't make this the right solution.


More information about the cfe-commits mailing list