[PATCH] D40939: [analyzer] Avoid element regions of void type.
Devin Coughlin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 18 10:45:17 PST 2017
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me, although I have a super nit about wording in a comment.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2181
+ // One of the forbidden LValue types! We still need to have sensible
+ // symbolic lvalues to represent this stuff.
+ if (T->isVoidType())
Super nit: Since we can't actually have lvalues for a forbidden lvalue type, we should instead call it a 'location' in the comment. "We still need to have sensible locations to represent this stuff".
More information about the cfe-commits