[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

Anton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 17 00:12:04 PST 2017

xgsa added inline comments.

Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339
     std::unique_ptr<ClangTidyOptionsProvider> OptionsProvider)
     : DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
+      Profile(nullptr),
xgsa wrote:
> Eugene.Zelenko wrote:
> > Please use default members initialization for DiagEngine and Profile.
> Actually, it is not necessary, as unique_ptr is initialized with nullptr by default. I have just removed initializing them here.
Sorry, you are right, just ignore my previous comment.


More information about the cfe-commits mailing list