[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

[Anton via Phabricator via cfe-commits]

xgsa created this revision.
xgsa added reviewers: aaron.ballman, alexfh.
xgsa added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.

As discussed in the previous review [1], diagnostics about incorrect usage of NOLINT comment was added, i.e..:

- usage of NOLINT with unknown check name;
- usage of NOLINT for line, where there is no diagnostics;
- usage of NOLINT without closing parenthesis.

I have covered the implementation with tests, but I haven't updated the documentation yet, because I'd like to approve the implemented approach in general. If nobody insists, I'd prefer updating the documentation in follow-up patches, because this will make the patch even bigger and the review longer.

[1] - https://reviews.llvm.org/D40671


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41326

Files:
  clang-tidy/ClangTidy.cpp
  clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tidy/ClangTidyDiagnosticConsumer.h
  test/clang-tidy/nolint-usage.cpp
  test/clang-tidy/nolint.cpp
  test/clang-tidy/nolintnextline.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41326.127259.patch
Type: text/x-patch
Size: 32851 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171216/a819c160/attachment-0001.bin>