[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment
Anton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Dec 16 14:38:28 PST 2017
xgsa created this revision.
xgsa added reviewers: aaron.ballman, alexfh.
xgsa added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
As discussed in the previous review , diagnostics about incorrect usage of NOLINT comment was added, i.e..:
- usage of NOLINT with unknown check name;
- usage of NOLINT for line, where there is no diagnostics;
- usage of NOLINT without closing parenthesis.
I have covered the implementation with tests, but I haven't updated the documentation yet, because I'd like to approve the implemented approach in general. If nobody insists, I'd prefer updating the documentation in follow-up patches, because this will make the patch even bigger and the review longer.
 - https://reviews.llvm.org/D40671
rCTE Clang Tools Extra
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 32851 bytes
Desc: not available
More information about the cfe-commits