[PATCH] D41280: [clangd] Don't use the optional "severity" when comparing Diagnostic.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 15 07:20:34 PST 2017

hokein added a comment.

In https://reviews.llvm.org/D41280#956597, @sammccall wrote:

> Can you give some more details about the problem (maybe offline)?
>  In my testing, I do see a FixIt in VSCode. It fails to apply, for reasons I don't yet understand.

As discussed offline, this is a regression issue of vscode-languageclient (from v3.0.0), has filed a bug to vscode team https://git.io/vbr29.

The current `vscode-clangd` extension is stale, which is not compatible with the latest clangd. If you use the latest client code in the `clangd/clients/clangd-vscode` together with this patch, you can see a FixIt, and can apply it successfully.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list