[PATCH] D41261: [libcxxabi][demangler] Special case demangling for pass_object_size attribute

George Burgess IV via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 15:54:35 PST 2017

george.burgess.iv added a comment.

Thanks for working on this!

Unfortunately, I've never touched demanglers before, so I don't think I can LGTM this patch.

> This attribute is mangled as if it was meant to match the <extended-qualifier> production.

Yup, definitely a mistake. Apologies. :)

Comment at: test/test_demangle.pass.cpp:29618
+    {"_ZZN7lambdas7LambdasEPcENK3$_0clEPvU17pass_object_size0", "lambdas::Lambdas(char*)::$_0::operator()(pass_object_size0 void*) const"},
+    {"_ZN8variadic6AsCtorC1EPKcU17pass_object_size0dz", "variadic::AsCtor::AsCtor(pass_object_size0 char const*, double, ...)"},
Nit: Can we have a test with pass_object_size(1) (or 2, or 3. Any of the 3 WFM), as well?

  rCXXA libc++abi


More information about the cfe-commits mailing list