[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.
Marc-Andre Laperle via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 14 07:22:58 PST 2017
malaperle added a comment.
In https://reviews.llvm.org/D40548#947081, @ioeric wrote:
> Hi Marc, the patch is not ready for review yet. I am still cleaning up the prototype and will let you know when it's ready for review.
I guess it was ready to review since it was submitted? ;)
Comment at: clangd/index/Index.h:134
+ virtual bool
+ fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req,
+ std::function<void(const Symbol &)> Callback) const = 0;
I think a more generic std::function would be useful, similar to the indexstore's filter
bool searchSymbols(llvm::function_ref<bool(IndexRecordSymbol, bool &stop)> filter,
rCTE Clang Tools Extra
More information about the cfe-commits