[PATCH] D40489: [clangd] Changed tracing interfaces

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 06:59:09 PST 2017

ilya-biryukov added inline comments.

Comment at: clangd/Trace.cpp:134
+  Callback = T->beginSpan(Ctx, Name);
+  if (!Callback)
+    return;
sammccall wrote:
> I'm not sure this is useful. Tracers that aren't interested in args can't opt out by providing a null callback, unless they also don't care about the end time.
> This seems unlikely (a null tracer, I guess)
One use-case that came to mind is turning the tracing on or off on per-request basis

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list