[PATCH] D40488: [clangd] Implemented tracing using Context

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 14 01:22:41 PST 2017

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.

Comment at: clangd/Trace.cpp:123
+  // Clone the context, so that the original Context can be moved.
+  this->Ctx.emplace(Ctx.clone());
This is a little unfortunate. Oh, well.

Comment at: clangd/Trace.h:42
+/// set up before calling any clangd-specific functions.
+class TracingSession {
hmm, `trace::TracingSession` seems redundant? Up to you

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list