[PATCH] D41148: [libcxx] implement <experimental/simd> declarations based on P0214R7.

[Tim Shen via Phabricator via cfe-commits]

timshen added inline comments.


================
Comment at: libcxx/include/experimental/simd:594
+
+#warning "<experimental/simd> is under construction and not for practical use for now."
+
----------------
EricWF wrote:
> I would just remove this. The `experimental` part of the name should say enough.
> 
> Also we normally wait until an implementation is mostly complete before landing it. 
> Also we normally wait until an implementation is mostly complete before landing it.

What's the definition of "landing"? I prefer to implement this library in multiple patches, does that mean I keep working on the next ones and finally commit all of them all at once? If that's the case, SGTM.


================
Comment at: libcxx/test/std/experimental/simd/traits.pass.cpp:15
+// [simd.traits]
+// template <class T> struct is_abi_tag;
+// template <class T> inline constexpr bool is_abi_tag_v = is_abi_tag<T>::value;
----------------
EricWF wrote:
> Please create a directory called `simd/traits/` and then put each trait in a separate test file under that directory.
> The `foo_v` tests should be in the same file as the `foo` tests.
> 
> 
Thanks! Done for all tests. Used directory names like "simd.cons", "simd.traits", "simd.casts".


https://reviews.llvm.org/D41148