[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

John Baldwin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 13 14:13:39 PST 2017

bsdjhb marked 2 inline comments as done.
bsdjhb added inline comments.

Comment at: src/AddressSpace.hpp:201
+inline uint64_t LocalAddressSpace::getRegister(pint_t addr) {
+#if defined(__LP64__) || (defined(__mips__) && defined(_ABIN32))
+  return get64(addr);
compnerd wrote:
> Can you use `__SIZEOF_POINTER__` rather than `__LP64__` please?  The former accounts for LLP64 environments as well.
I wonder if we should adjust the #if condition used to control the types of pint_t and sint_t earlier in this file to also use __SIZEOF_POINTER__ (as a separate change)?


More information about the cfe-commits mailing list