[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 13 08:17:50 PST 2017
aaron.ballman added a comment.
In https://reviews.llvm.org/D36892#953953, @lebedev.ri wrote:
> In https://reviews.llvm.org/D36892#953891, @aaron.ballman wrote:
> > I think you're set to commit this
> Should i commit it though?
> Until licensing concerns with https://reviews.llvm.org/D36836 are finally magically resolved and it is committed, there won't be any users, and since there is no tests for this, that would be a dead code with all the consequences.
Hmm, I thought we had other tests that could make use of this functionality? However, I might be misremembering. Hold off on committing until there's test coverage, but it'd be good to look at existing tests to see if any of them can be modified.
rCTE Clang Tools Extra
More information about the cfe-commits