[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 13 07:27:46 PST 2017

aaron.ballman added a comment.

In https://reviews.llvm.org/D40671#953291, @xgsa wrote:

> @aaron.ballman, sorry for my insistence, but it seems all the comments are fixed and the patch is ready for commit or am I missing something? Could you please commit it on my behalf, as I don't have rights to do that?

The check now LGTM, but I am going to wait to commit in case @alexfh has concerns regarding unknown check names.

FWIW, I think we should do something about unknown check names in NOLINT comments, but that can be done as a follow-up patch. If we're ignoring the comment, we might want to diagnose that fact so users have an idea what's going on.


More information about the cfe-commits mailing list