[PATCH] D40486: [clangd] Implemented logging using Context

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 12 08:03:15 PST 2017

ilya-biryukov added inline comments.

Comment at: clangd/Function.h:44
+            /// A sfinae-check that Callable can be called with Args...
+            class = decltype(std::declval<Callable>()(std::declval<Args>()...),
+                             void())>
We need this check to make `ClangdServer::codeComplete` overloads work. Without it, overloading thinks `UniqueFunction` can be constructed from any type, so we end up getting ambig between the two overloads when calling it in a following way: `codeComplete(Ctx, File, Pos, CCOpts, OverridenContents)`.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list