[PATCH] D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref.

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 12 06:45:17 PST 2017


mclow.lists added a comment.

> Avoid MSVC "warning C4293: '<<': shift count negative or too big, undefined behavior". 
>  MSVC sees (1ULL << N) and warns - being guarded by const bool canFit is insufficient. A small change to the code

Your compiler needs to either (a) get much smarter about its warnings, or (b) stop warning about this.  It's just WRONG here.


https://reviews.llvm.org/D41030





More information about the cfe-commits mailing list