[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 12 02:21:02 PST 2017

ilya-biryukov added inline comments.

Comment at: clangd/Context.h:169
+  struct ContextData {
+    // We need to make sure Parent outlives the Value, so the order of members
+    // is important. We do that to allow classes stored in Context's child
sammccall wrote:
> Is this comment still true/relevant?
> I thought the motivating case was Span, but Span now stores a copy of the parent pointer (and ContextData isn't accessible by it).
I'd argue we still want to keep this invariant, it gives a natural order of destruction.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list