[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor
Marshall Clow via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 11 10:57:21 PST 2017
mclow.lists added a comment.
This looks good to me; with a couple of nits.
Comment at: test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp:26
+ assert(this->eback() == 0);
+ assert(this->gptr() == 0);
Not zero, please. `nullptr` or `NULL` .
`nullptr` would be better, but we can't assume c++11 here, so I guess it's `NULL`.
More information about the cfe-commits