[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

Mon Dec 11 08:09:14 PST 2017

alexfh added a comment.

In https://reviews.llvm.org/D41056#950605, @khuttun wrote:

> In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote:
>
> > May be //bugprone// is better module then //misc//?
>
>
> Maybe. I can move it if all the reviewers think that it would be better suited there.

Yup, bugprone- should be a better category for this, IMO.

I wonder whether libc++ folks are interested in marking unique_ptr::release() with `__attribute__ ((warn_unused_result))`. A compiler warning (with -Werror) would be a better protection against this kind of a bug.

Repository:
  rL LLVM

https://reviews.llvm.org/D41056