[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/Context.h:92
+  ContextBuilder derive() const &;
+  ContextBuilder derive() const &&;
+
----------------
sammccall wrote:
> `&&`, not `const&&` :-)
> 
> Maybe add a trailing `//takes ownership`
Right. Copy-paste is gonna kill me some day.
Added the comment, too. Although that should be obvious from the `&&` in the signature.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40485