[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

Andrey Khalyavin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 4 23:03:51 PST 2017


halyavin marked an inline comment as done.
halyavin added inline comments.


================
Comment at: src/support/runtime/exception_pointer_msvc.ipp:119-123
+#ifdef _M_AMD64
+    RtlPcToFileHeader(
+        reinterpret_cast<PVOID>(const_cast<EHThrowInfo*>(throw_info)),
+        &image_base);
+#endif
----------------
majnemer wrote:
> Can't you use the image_base field in throw_info?
The structure throw_info doesn't have image_base field, it is EHParameters that does. Unfortunately EHParameters is not available in make_exception_ptr.


https://reviews.llvm.org/D40071





More information about the cfe-commits mailing list