[PATCH] D39279: Stringizing raw string literals containing newline

Taewook Oh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 4 10:35:34 PST 2017


twoh updated this revision to Diff 125368.
twoh added a comment.

Thanks @jkorous-apple for the comment. I think your suggestion is a more
precise description for the implementation, and adjusted the comments
accordingly.

I intentionally didn't add the details to the comments for the header,
as LLVM coding standard "Don’t duplicate the documentation comment in
the header file and in the implementation file. ... implementation files
can include additional comments (not necessarily in Doxygen markup) to
explain implementation details as needed." I'd like to leave it as of
now if you're not strongly against it.

Thank you again!


https://reviews.llvm.org/D39279

Files:
  include/clang/Lex/Lexer.h
  lib/Lex/Lexer.cpp
  test/Preprocessor/macro_raw_string.cpp
  unittests/Lex/LexerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39279.125368.patch
Type: text/x-patch
Size: 18048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171204/697d8886/attachment-0001.bin>


More information about the cfe-commits mailing list