[PATCH] D39430: [clangd] various fixes

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 3 21:13:11 PST 2017


malaperle added a comment.

> - Look up in parent directories for a .clang-format file. Use "LLVM" as fallback style.
> - Move cached fixits to ClangdServer, remove fixits once the client closes the document.
> - Fix translations between LSP rows/cols (0-based) and clang row/cols (1-based).

I'd rather keep one commit per fix or feature. I would think the clang-format part should be one commit/review on its own. But I'm not very familiar with the practices here so I'll let others comment.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D39430





More information about the cfe-commits mailing list