[PATCH] D40731: Integrate CHash into CLang

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Please run Clang-format and Clang-tidy modernize over newly added code.



================
Comment at: include/clang/AST/CHashVisitor.h:1
+#ifndef __CHASH_VISITOR
+#define __CHASH_VISITOR
----------------
Please loon onto other headers for inclusion guards style.


================
Comment at: include/clang/AST/CHashVisitor.h:9
+#include "llvm/Support/MD5.h"
+
+
----------------
No empty lines between header groups.


================
Comment at: include/clang/AST/CHashVisitor.h:14
+#include <map>
+
+
----------------
Unnecessary empty line.


================
Comment at: include/clang/AST/CHashVisitor.h:18
+
+    namespace CHashConstants {
+        enum  {
----------------
Please add empty line below.


================
Comment at: include/clang/AST/CHashVisitor.h:153
+        };
+    }
+
----------------
} // namespace CHashConstants

Please add empty line above.


================
Comment at: include/clang/AST/CHashVisitor.h:159
+
+        typedef clang::RecursiveASTVisitor<CHashVisitor<H, HR>> Inherited;
+    public:
----------------
Please use using instead of typedef same in other places.


================
Comment at: include/clang/AST/CHashVisitor.h:160
+        typedef clang::RecursiveASTVisitor<CHashVisitor<H, HR>> Inherited;
+    public:
+        typedef H Hash;
----------------
Please add empty line above.


================
Comment at: include/clang/AST/CHashVisitor.h:446
+        Hash &topHash() { return HashStack.back(); }
+
+
----------------
Unnecessary lines.


================
Comment at: include/clang/AST/CHashVisitor.h:450
+
+}
+#endif
----------------
} // namespace clang


================
Comment at: include/clang/AST/CHashVisitor.h:451
+}
+#endif
----------------
#endif // <inclusion guard>


Repository:
  rC Clang

https://reviews.llvm.org/D40731