[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 1 07:47:24 PST 2017


klimek added a comment.

In https://reviews.llvm.org/D33589#942128, @Typz wrote:

> Indeed, looks good, thanks!
>
> Though that exacerbates the alignment issue, I now get things like this:
>
>   enum {
>     SomeLongerEnum, // comment
>     SomeThing,      // comment
>     Foo, // something
>   } 
>                               ^ (column limit)
>   
>
> The comment on 'Foo' would overflow a bit, but it gets unindented during "alingment" stage, which kind of 'breaks' the decision that was made earlier on *not* to break the comment...


Ok, that seems like a different bug that we can fix in alignment, though :)


https://reviews.llvm.org/D33589





More information about the cfe-commits mailing list