[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: docs/clang-tidy/checks/fuchsia-multiple-inheritance.rst:46
+
+See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md
----------------
juliehockett wrote:
> alexfh wrote:
> > This is not about the check, rather about the underlying style guide. The document linked here doesn't explain why certain features are disallowed. I'd suggest putting some effort in expanding the document to include reasoning for each rule (e.g. see https://google.github.io/styleguide/cppguide.html#Multiple_Inheritance for a related rule in the Google C++ style guide).
> Good point -- we're looking into updating it. Thanks!
Hmm, the document linked here explicitly says that multiple inheritance of non-interface classes is allowed:

> * Allowed
>    * ...
>    * Multiple implementation inheritance
>        * But be judicious. This is used widely for e.g. intrusive container mixins.

That seems to directly contradict the warning produced by this check, `inheriting mulitple classes which aren't pure virtual is disallowed`. Should it just say "... is discouraged"?


https://reviews.llvm.org/D40580