[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 29 07:55:00 PST 2017


jkorous-apple added inline comments.


================
Comment at: tools/libclang/CIndexer.cpp:108
+  // Write out the information about the invocation to it.
+  auto WriteStringKey = [&](StringRef Key, StringRef Value) {
+    OS << R"(")" << Key << R"(":")";
----------------
Nit: Maybe capturing &OS is enough?


Repository:
  rC Clang

https://reviews.llvm.org/D40527





More information about the cfe-commits mailing list