[PATCH] D40507: [clang-tidy] Move more checks from misc- to performance-

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 28 05:40:22 PST 2017


xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

Found one possible problem. Once fixed, LG!



================
Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:33
+#include "../performance/MoveConstArgCheck.h"
+#include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../readability/BracesAroundStatementsCheck.h"
----------------
Don't you need to add performance module to link to the HICPP module to avoid link errors? 


================
Comment at: clang-tidy/performance/MoveConstArgCheck.h:19
 
-class MoveConstantArgumentCheck : public ClangTidyCheck {
+class MoveConstArgCheck : public ClangTidyCheck {
 public:
----------------
Is there any specific reason to rename this class? I am ok with the change, just wondering.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40507





More information about the cfe-commits mailing list