[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 28 04:47:53 PST 2017


xazax.hun added inline comments.


================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:262
+std::vector<std::string> ClangTidyContext::getEnabledClangDiagnostics() {
+  llvm::SmallVector<unsigned, 5000> Diags;
+  DiagnosticIDs::getAllDiagnostics(diag::Flavor::WarningOrError, Diags);
----------------
I am wondering if this is still a good candidate to be a small vector with this size. Maybe a regular vector with a reserve might be better?


https://reviews.llvm.org/D38171





More information about the cfe-commits mailing list