[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 28 00:40:28 PST 2017


rjmccall accepted this revision.
rjmccall added a comment.

In https://reviews.llvm.org/D40275#937010, @tra wrote:

> In https://reviews.llvm.org/D40275#933253, @tra wrote:
>
> > @rjmccall : are you OK with this approach? If VLA is not supported by the target, CUDA is handled as a special case so it can emit deferred diag, OpenMP reports an error only if shouldDiagnoseTargetSupportFromOpenMP() allows it, and everything else does so unconditionally.
>
>
> @rjmccall : ping.


Sorry for the delay; I took Thanksgiving week off.  Yes, I think this patch is fine now, thanks.


https://reviews.llvm.org/D40275





More information about the cfe-commits mailing list