[PATCH] D40112: [CodeGen][X86] Fix handling of __fp16 vectors

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added inline comments.


================
Comment at: lib/CodeGen/CGExprScalar.cpp:954
     if (DstTy->isFloatingPointTy()) {
-      if (!CGF.getContext().getLangOpts().HalfArgsAndReturns)
+      if (CGF.getContext().getTargetInfo().useFP16ConversionIntrinsics())
         return Builder.CreateCall(
----------------
This (and in the other places in the patch) means that regardless of `HalfArgsAndReturns` state we want to generate an intrinsic call if `useFP16ConversionIntrinsics()` is true, is that always the intended behavior?  


https://reviews.llvm.org/D40112