[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

[Devin Coughlin via Phabricator via cfe-commits]

dcoughlin accepted this revision.
dcoughlin added a comment.

LGTM, but as noted inline you should update the new llvm_unreachable() to have a more descriptive error message.

Do you have commit access or do you need someone to commit this for you?



================
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:701
+    }
+    llvm_unreachable("Unexpected ProgramPoint");
   } else {
----------------
This assertion should probably say something like "Unexpected CFG element at front of block".


https://reviews.llvm.org/D37187