[PATCH] D40488: [clangd] Implemented tracing using Context

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 27 04:57:57 PST 2017


ilya-biryukov planned changes to this revision.
ilya-biryukov added inline comments.


================
Comment at: clangd/JSONRPCDispatcher.h:80
+  // Ctx must be before Tracer!
   Context Ctx;
   JSONOutput &Out;
----------------
This is still wrong, `Context` is used by `Tracer` internally and should not be moved.


https://reviews.llvm.org/D40488





More information about the cfe-commits mailing list