[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

[Ivan Donchevskii via Phabricator via cfe-commits]

yvvan added inline comments.


================
Comment at: tools/libclang/CIndex.cpp:6445
+  struct PostChildrenAction {
+      CXCursor cursor;
+      enum Action { Invalid, Ignore, Postpone } action;
----------------
4 spaces instead of 2


================
Comment at: tools/libclang/CIndex.cpp:6535
+        ChildAction.action == PostChildrenAction::Ignore)
+      return true;
+  }
----------------
missing {}


================
Comment at: tools/libclang/CIndex.cpp:6666
+  if (IsIgnoredChildCursor(cursor))
+      return CXChildVisit_Continue;
+
----------------
4 spaces indentation instead of 2


================
Comment at: tools/libclang/CIndex.cpp:6860
+    if (ChildAction.action == PostChildrenAction::Postpone)
+      HandlePostPonedChildCursor(ChildAction.cursor,
+                                 Info.BeforeChildrenTokenIdx);
----------------
cover with {}


================
Comment at: tools/libclang/CIndex.cpp:6888
+      const SourceLocation fixedEnd =
+          RefNameRange.getEnd().getLocWithOffset(-1);
+      RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd);
----------------
4 spaces indentation instead of 2


================
Comment at: tools/libclang/CIndex.cpp:6892
+      const RangeComparisonResult ComparisonResult =
+          LocationCompare(SrcMgr, TokenLocation, RefNameRange);
+
----------------
same


https://reviews.llvm.org/D40481